Does war bring any benefits to an economy?

It increases production of food, clothing, and weapons that are necessary for the army. And if you are talking about the nineteenth and twentieth centuries, it also allowed women to work in factories and move away from the traditional home jobs, since the men were occupied at the front lines.

If you gain land through the war you can gain new resources to use in trade and new ports to trade with.