In what ways did the war affect

American citizens?

The war's effects were varied and far-reaching. The war decisively ended the depression itself. The federal government emerged from the war as a potent economic actor, able to regulate economic activity and to partially control the economy through spending and consumption.

Tax is increased, job opportunities are decreased. This also depends on the specific war you are talking about.